Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArtifactHub doesn't detect OCI-based charts using semver tag with + char replaced by _ #3762

Open
JuniorJPDJ opened this issue Apr 13, 2024 · 1 comment
Labels

Comments

@JuniorJPDJ
Copy link

Describe the bug
Helm utility automatically replaces + with _ when pushing charts to OCI-based repository. ArtifactHub entirely skips versions with this character as it thinks it's non-semver compliant. OCI doesn't natively support + character in tags.

I'm uploading PR charts with 0.0.0+PR-# versions and those are not visible in the AF.

To Reproduce
Steps to reproduce the behavior:

  1. Add OCI-based Charts repository to AF.
  2. Upload chart with + character in the version using official helm utility (it gets uploaded with + sign replaced by _).
  3. See the ArtifactHub not grabing it at all.

Additional context
Add any other context about the problem here.

@JuniorJPDJ JuniorJPDJ added the bug label Apr 13, 2024
@tegioz
Copy link
Collaborator

tegioz commented Apr 15, 2024

Hi @JuniorJPDJ 👋

ArtifactHub entirely skips versions with this character as it thinks it's non-semver compliant

ArtifactHub requires packages versions to be valid semver. The problem is that 0.0.0_PR-1 is not actually a valid semver version. You can test it yourself here, which is basically the same as we do when processing the tags of an OCI reference. But even if it was, we could still have an issue, as we could have processed the version but display incorrect installation instructions (i.e. displaying an _ in the installation command expecting the Helm CLI tool to replace it, or viceversa).

I understand the need for this workaround on the Helm side, due to the OCI references naming rules. We could consider reverting that change when listing tags for OCI based Helm repositories, but we also need to be mindful about other artifact kinds. Let us think about this a bit to see the implications it may have on other parts of Artifact Hub 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants