Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AH linter does not support git-based versioning structure for tekton kinds #3691

Open
ksimon1 opened this issue Mar 6, 2024 · 4 comments
Open

Comments

@ksimon1
Copy link

ksimon1 commented Mar 6, 2024

Is your feature request related to a problem? Please describe.
AH linter contains hardcoded directory-based type of versioning for tekton kinds - https://github.com/artifacthub/hub/blob/master/cmd/ah/lint.go#L386.
According to https://artifacthub.io/docs/topics/repositories/tekton-tasks/, the git-based versioning is "newer and recommended", but ah linter does not supports it.
Describe the solution you'd like
AH linter supports both types of versioning.

@ksimon1
Copy link
Author

ksimon1 commented Mar 6, 2024

I am closing this issue, because the root cause is probably caused by a bug #3692

@tegioz
Copy link
Collaborator

tegioz commented Mar 6, 2024

Hi again @ksimon1!

According to https://artifacthub.io/docs/topics/repositories/tekton-tasks/, the git-based versioning is "newer and recommended"

I think we'll update the docs to remove that part. The tasks and pipelines catalogs at https://github.com/tektoncd/catalog still use directory-based structure. And I personally prefer that one as well, as IIRC the git-based structure forces you to bump the version of all packages in the same repository at the same time, as the version is taken from the git tag. Please see the issue/comment referenced below for more details.

From #2326 (comment):

This one is also related to versions. In Artifact Hub, every package (a task or pipeline in this case) must have a version. Given that all tasks in a catalog will share the same version, I understand that sometimes the version for a task will be bumped even though that particular task may not have changed at all. Users in Artifact Hub can subscribe to new releases notifications and, in cases like the one just mentioned, they may be notified about a new package release when nothing actually changed, which could be a bit annoying for users. I've already discussed this concern with @QuanZhang-William in Slack, and he mentioned that you were moving to smaller repos with fewer (or even one) packages per repo, which would definitely help.

@tegioz
Copy link
Collaborator

tegioz commented Mar 6, 2024

I think we'll update the docs to remove that part.

Self-correction: this was requested by the Tekton team, so we'll leave it as it is 😇

@ksimon1
Copy link
Author

ksimon1 commented Mar 6, 2024

@tegioz Thanks for the information. I am reopening this issue, because we will be using AH linter for our tasks / pipelines which will be using git based versioning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants