-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AH linter does not support git-based versioning structure for tekton kinds #3691
Comments
I am closing this issue, because the root cause is probably caused by a bug #3692 |
Hi again @ksimon1!
I think we'll update the docs to remove that part. The tasks and pipelines catalogs at https://github.com/tektoncd/catalog still use directory-based structure. And I personally prefer that one as well, as IIRC the git-based structure forces you to bump the version of all packages in the same repository at the same time, as the version is taken from the git tag. Please see the issue/comment referenced below for more details. From #2326 (comment):
|
Self-correction: this was requested by the Tekton team, so we'll leave it as it is 😇 |
@tegioz Thanks for the information. I am reopening this issue, because we will be using AH linter for our tasks / pipelines which will be using git based versioning. |
Is your feature request related to a problem? Please describe.
AH linter contains hardcoded directory-based type of versioning for tekton kinds - https://github.com/artifacthub/hub/blob/master/cmd/ah/lint.go#L386.
According to https://artifacthub.io/docs/topics/repositories/tekton-tasks/, the git-based versioning is "newer and recommended", but ah linter does not supports it.
Describe the solution you'd like
AH linter supports both types of versioning.
The text was updated successfully, but these errors were encountered: