Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to swipe to bottom of sidr menu on mobile device when menu is taller than viewport #322

Open
kbrinner opened this issue Mar 3, 2017 · 1 comment

Comments

@kbrinner
Copy link

kbrinner commented Mar 3, 2017

I have implemented the Sidr menu on a Drupal site - see http://sidr-txlg.pantheonsite.io/. The menu is taller than the phone's viewport, and there are some undesirable effects when trying to swipe down to the bottom of the menu.

When you first click the hamburger menu to trigger opening of the sidr, everything looks fine. However, when you start to swipe down to see the rest of the menu, rather than the sidr menu swiping as you might expect, the body moves down quickly, and the sidr moves down slowly. Even when you scroll to the bottom of the body, you still aren't at the bottom of the sidr menu. See attached screenshots - even the 'Trying to swipe to the bottom:' screenshot hasn't reached the bottom of the menu, there is a search bar at the bottom that is never visible.

This is only apparent when viewing the website on an actual mobile device - if you check it out in Chrome or Firefox using the dev tools, this behavior isn't apparent.

I have tried a number of different things, including changing the overflow-y on the div.sidr to either visible or scroll, adding (unsupported?) -webkit-overflow-scrolling: touch; to div.sidr, changing the height from 100% to a fixed height to make it even taller, but nothing seems to change this.

Thank you for the great plugin, but I would appreciate any help with this. If you know of any examples where a tall sidr menu has been used without this issue, I'd love to compare them to see what they've done differently.

Sidr menu after first opening:
top of menu
Trying to swipe to the bottom:
swipe to bottom

@kbrinner
Copy link
Author

kbrinner commented Mar 3, 2017

I have found a potential workaround, but this behavior doesn't seem ideal. When I added 400px of padding to the bottom of the search bar that was previously unaccessible via swiping down, it now is accessible. Seems like Sidr needed some extra space at the bottom in order to have the swipe functionality work better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant