Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it so -[ORSSerialPort dealloc] also closes the port if needed #141

Open
armadsen opened this issue Feb 17, 2019 · 0 comments
Open

Make it so -[ORSSerialPort dealloc] also closes the port if needed #141

armadsen opened this issue Feb 17, 2019 · 0 comments
Assignees
Milestone

Comments

@armadsen
Copy link
Owner

This is currently difficult because closing a port is an asynchronous operation, and therefore can't be triggered by the time the object is being deallocated. One possible fix is to create a helper object that is responsible for actually closing the port, whose lifetime is independent of the ORSSerialPort instance, and that can keep itself alive until the port is actually closed.

@armadsen armadsen added this to the 2.1 milestone Feb 17, 2019
@armadsen armadsen self-assigned this Feb 17, 2019
@armadsen armadsen changed the title Make it so -dealloc also closes the port if needed Make it so -[ORSSerialPort dealloc] also closes the port if needed Feb 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant