Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a robust lazy resolution system, integrate with transforms #944

Open
ssalbdivad opened this issue May 3, 2024 · 0 comments
Open

Comments

@ssalbdivad
Copy link
Member

The current transform behavior for cyclic nodes is not robust. I slapped together a ctx with seen and lazy resolutions, but currently lazilyResolve is limited to root nodes, whereas to support this it needs to be able to handle any composite node kind (see Node.transform at ark/schema/node.ts).

My initial thoughts were a scope should keep create a unique id per transformation when the root transform call is made.

Then each id in seen would be lazily resolved to that id prefixed with the transform id.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

1 participant