-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
track sanitizing migration slated for FF127/8 #1837
Comments
we have diffs issues, and I am aware of the new Data Sanitation and rollout - it's currently nightly only sorry, just saw your last sentence after I labelled also, pretty sure the migrated prefs will be changed at runtime, and setting them to false won't be effective, otherwise I think the migration will match exactly what you have in your overrides (super early nightly migration was hit and miss) |
^ in other words, 99% sure there's nothing for me to do until AFTER the rollout |
here's the meta - https://bugzilla.mozilla.org/show_bug.cgi?id=1853996 and here's the new rollout - https://bugzilla.mozilla.org/show_bug.cgi?id=1895612 hope this lands in 128 so the next ESR is on the same playing field Also, FYI, putting migrate prefs in the user.js is fraught (edit: with danger!!), because prefsCleaner would reset them and cause another migration (IIUIC) |
The new sanitation thing is more than "just" the GUI change right? because FF126 definitely has the new dialog thingy |
nah, they rolled it back, as I said. If they haven't hooked up the new prefs, they can't really hook up the new UI .. and if they hook up the new UI they'll need the new prefs - so it's all about the migration .. but who knows, maybe they can toggle each on individually but there's no point in doing that but I've reopened so we have a issue to track it (but I doubt we'll need it) |
^ this is a profile where I have no user.js (so nothing being cleared/reset) but I did set it up to always sanitize everything on close - but I can't see that affected the migration, because they have to migrate everyone at some point |
it's already tee'd up for 128: https://bugzilla.mozilla.org/show_bug.cgi?id=1895612#c1 (won't be pushed since we're in RC week) edit: and barring any mishaps they could always backport it to 127 |
aah, I see |
I have beta here as well, but I almost never use it because it hates running concurrently with any other firefox.exe |
https://bugzilla.mozilla.org/show_bug.cgi?id=1895612#c5
|
so this means e.g. nice, four options instead of 7- I think I can add this ahead of time without too messy |
and that should just leave cpd which I think is all the new prefs in 125 - I'll deal with them there |
closing - this wasn't as messy as I thought - the 4 _v2 prefs slotted in nicely - thanks @MagicalDrizzle , this did need it's own special issue since the prefs are from old timey diffs and stuff PS: adding the migrated prefs would mean they would get reset with prefsCleaner and cause repeat migrations which can get messy for users since it would happen after user.js (I think) |
there's also a |
https://www.mozilla.org/en-US/firefox/126.0beta/releasenotes/
Maybe we should enforce the bottom two prefs as false to prevent data loss while this new thing is figured out?
The text was updated successfully, but these errors were encountered: