Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Fix examples for connected endpoints using deprecated data-model in input-varaibles.md #3989

Merged

Conversation

Shivani-gslab
Copy link
Contributor

@Shivani-gslab Shivani-gslab commented May 14, 2024

Change Summary

Fix examples for connected endpoints using deprecated data-model in input-varaibles.md

Related Issue(s)

Fixes #3905

Component(s) name

arista.avd.eos_designs

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-3989
# Activate the virtual environment
source test-avd-pr-3989/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@deprecated_connected_endpoints#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,deprecated_connected_endpoints --force
# Optional: Install AVD examples
cd test-avd-pr-3989
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added the role: eos_designs issue related to eos_designs role label May 14, 2024
@Shivani-gslab Shivani-gslab changed the title Fix(Doc): Fix examples for connected endpoints using deprecated data-model in input-varaibles.md Doc: Fix examples for connected endpoints using deprecated data-model in input-varaibles.md May 14, 2024
@MaheshGSLAB MaheshGSLAB marked this pull request as ready for review May 14, 2024 13:12
@MaheshGSLAB MaheshGSLAB requested review from a team as code owners May 14, 2024 13:12
@ClausHolbechArista ClausHolbechArista requested a review from a team May 17, 2024 07:18
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label May 17, 2024
@gmuloc gmuloc merged commit fb34bf2 into aristanetworks:devel May 17, 2024
37 checks passed
@Shivani-gslab Shivani-gslab deleted the deprecated_connected_endpoints branch May 21, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Doc role: eos_designs issue related to eos_designs role state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some examples for connected endpoints are using deprecated data models
4 participants