Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_validate_state): Added the validation for IP security connections #3911

Merged
merged 10 commits into from
May 31, 2024

Conversation

MaheshGSLAB
Copy link
Contributor

Change Summary

Added the validation for IP security connections. This will only validate connections for default vrf.

Related Issue(s)

Fixes #3890

Component(s) name

arista.avd.eos_validate_state

Proposed changes

Changes will collect the static peers from router path-selection and validate the ip sec connection to those peer in default VRF.

How to test

Run the molecule or test it on lab with eos_validate_state in playbook.
Note: Need ANTA==0.14.0 to test this.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_validate_state state: CI Updated CI scenario have been updated in the PR labels Apr 26, 2024
@MaheshGSLAB MaheshGSLAB marked this pull request as ready for review April 26, 2024 06:32
@MaheshGSLAB MaheshGSLAB requested review from a team as code owners April 26, 2024 06:32
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the state: conflict PR with conflict label Apr 26, 2024
@github-actions github-actions bot removed the state: conflict PR with conflict label Apr 29, 2024
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@MaheshGSLAB MaheshGSLAB requested a review from gmuloc May 16, 2024 11:26
Copy link

sonarcloud bot commented May 27, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@MaheshGSLAB MaheshGSLAB requested a review from gmuloc May 27, 2024 09:14
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label May 28, 2024
Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann merged commit 537184e into aristanetworks:devel May 31, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat(eos_validate_state): Add validation for Ipsec connection
4 participants