-
-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unmountOnHide doesn't respect closing animation when Dialog is used without explicit store #3403
Labels
Comments
At the moment, if a store isn't provided (either through the This ensures we run as little code as possible when the dialog is unmounted. But we can potentially support this in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current behavior
Closing a dialog that has
open
,onClose
andunmountOnHide
props (see example below) doesn't wait for the closing animation before unmounting. When usingstore
andunmountOnHide
props, everything works as expected.Steps to reproduce the bug
Expected behavior
Dialogs should finish animation regardless of whether store is passed as a prop or is created internally.
Workaround
Construct
useStore
manually.#3403 (comment)
Possible solutions
No response
The text was updated successfully, but these errors were encountered: