-
-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[popover]: crash on Chrome when using portalElement #3229
Labels
Comments
Hey @marg51 That's probably related to the following line which we should address properly in a near future. Both ariakit/packages/ariakit-react-core/src/portal/portal.tsx Lines 83 to 99 in a4ea0be
Using any other element instead of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current behavior
Hello :)
On some Chrome browsers, when using
portalElement
, the tab crashes when opening the popover.The popover does open for a few seconds before the tab crashes, as if there was some kind of infinite loop.
There is nothing in the console before the crash.
It's still unclear which browsers are impacted: for the same version, some people can replicate the crash, but not everyone -› there is an unknown external factor.
One of the Chrome versions impacted:
Version 120.0.6099.109 (Official Build) (arm64)
We were initially on version
0.2.16
but we can also replicate it with the latest version.On a team of 4 ( on mac )
Minimal reproduction step:
https://stackblitz.com/edit/vitejs-vite-dmafri?file=package.json,src%2FApp.tsx&terminal=dev
And thank you for the hard-work, we truly love using ariakit ❤️
Steps to reproduce the bug
This should be enough to reproduce it:
Expected behavior
no crashes
Workaround
We've used react's
createPortal
insteadPossible solutions
No response
The text was updated successfully, but these errors were encountered: