UI: Containerset nodes receive the wrong podname

[instauro]

Pre-requisites

• I have double-checked my configuration
• I have tested with the :latest image tag (i.e. quay.io/argoproj/workflow-controller:latest) and can confirm the issue still exists on :latest. If not, I have explained why, in detail, in my description below.
• I have searched existing issues and could not find a match for this bug
• I'd like to contribute the fix myself (see contributing guide)

What happened/what did you expect to happen?

When trying to get the logs for a (any) containerset container in the UI, the user is faced with a blank page.

This is due to the podname being incorrectly calculated for these nodes, which makes the request to the backend return an empty response.

Expected behavior would be to be able to view the logs in similar fashion as for pod nodes.

Version

latest

Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.

apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
  generateName: graph-
  labels:
    workflows.argoproj.io/test: "true"
  annotations:
    workflows.argoproj.io/description: |
      This workflow demonstrates running a graph of tasks within containers in a single pod.
    workflows.argoproj.io/version: ">= 3.1.0"
spec:
  entrypoint: main
  templates:
    - name: main
      containerSet:
        containers:
          - name: a
            image: argoproj/argosay:v2
          - name: b
            image: argoproj/argosay:v2
            dependencies: ["a"]
          - name: c
            image: argoproj/argosay:v2
            dependencies: ["a"]
          - name: d
            image: argoproj/argosay:v2
            dependencies: ["b", "c"]

Logs from the workflow controller

N/A

Logs from in your workflow's wait container

N/A

[agilgur5]

Hmm this seems like a duplicate of #10157; @isubasinghe I thought you tested that this was working?

[isubasinghe]

@agilgur5 I did test if the live logs were showing, this sounds like a different issue.

[instauro]

The issue here is that the initial pod name is being incorrectly calculated, which gives the user empty logs when pressing the 'logs' button. If the user then manually selects the pod for their container they do indeed see the logs.

[isubasinghe]

Right that makes sense, thanks. I think I was selecting the containers individually when I tested #10157 so never noticed this issue. Thanks, will have a look into your PR.

[instauro]

To be clear; logs are not currently shown when selecting containers individually. You can show them by manually selecting the pod for the selected container in the WorkflowLogsViewer.