-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect redirect after Login when terminating TLS with reverse proxy #13031
Labels
Comments
ryancurrah
changed the title
Users Not Returned to Original Page After Login
Users Not Returned to Original Page After Login When Using Reverse Proxy and No TLS
May 10, 2024
ryancurrah
changed the title
Users Not Returned to Original Page After Login When Using Reverse Proxy and No TLS
Users Not Returned to Original Page After Login When Using Reverse Proxy with No TLS Configured
May 10, 2024
agilgur5
changed the title
Users Not Returned to Original Page After Login When Using Reverse Proxy with No TLS Configured
Incorrect redirect after Login with terminating TLS with reverse proxy
May 10, 2024
agilgur5
changed the title
Incorrect redirect after Login with terminating TLS with reverse proxy
Incorrect redirect after Login when terminating TLS with reverse proxy
May 10, 2024
Follow-up to this Slack thread
We could potentially use the request's protocol to determine this. But EDIT: Here's another redirect line that depends on it that should be changed too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Pre-requisites
:latest
image tag (i.e.quay.io/argoproj/workflow-controller:latest
) and can confirm the issue still exists on:latest
. If not, I have explained why, in detail, in my description below.What happened/what did you expect to happen?
Description:
When clicking an Argo Workflows link, if I'm not logged in, I'm redirected to the login page. After logging in, I'm redirected to the workflows page instead of the original page I was trying to access.
Steps to reproduce:
Debugging information:
strings.HasPrefix(cookie.Value, prefix)
always evaluates to false due to a mismatch between the HTTP and HTTPS schemes.secure
variable is set to false becauseopts.TLSConfig
is nil, indicating that Argo Server is not terminating TLS. Instead, a reverse proxy is used to terminate TLS. So https://github.com/argoproj/argo-workflows/blob/v3.5.5/server/auth/sso/sso.go#L345-L348 ends up beinghttp
when infact we are usinghttps
.Expected behavior:
After logging in, the user should be redirected to the original project they were trying to access, not the last viewed project.
Version: Argo Workflows v3.5.5
Version
v3.5.5
Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.
n/a
Logs from the workflow controller
Logs from in your workflow's wait container
The text was updated successfully, but these errors were encountered: