Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when SyncOption's ServerSideApply=true, Blue/Green deployments doesn't work well #3437

Open
2 tasks
kingbj940429 opened this issue Mar 10, 2024 · 2 comments
Open
2 tasks
Labels
bug Something isn't working

Comments

@kingbj940429
Copy link

Checklist:

  • I've included steps to reproduce the bug.
  • I've included the version of argo rollouts.

Describe the bug

When SyncOption is set to ServerSideApply=true, features such as autoPromoteEnabled and AnalysisRun are not generated.

To Reproduce

I'm deploying a application using below yaml

Even though the AnalysisTemplate exists, AnalysisRun is not generated. Additionally, despite autoPromoteEnable being set to false, automatic promotion still occurs. Moreover, options such as previewReplicaCount in Blue/Green deployments are not functioning correctly.

image

apiVersion: argoproj.io/v1alpha1
kind: ApplicationSet
metadata:
  name: app-demo
  namespace: continuous-system
spec:
  generators:
    - list:
        elements:
          - deployTier: dev
            targetRevision: feature-0b154b
  template:
    metadata:
      name: "app-demo-{{deployTier}}"
      namespace: continuous-system
    spec:
      project: pf
      destination:
        namespace: insight
        server: "https://kubernetes.default.svc"
      source:
        chart: app-demo
        repoURL: "https://privates/repository/helm-hosted"
        targetRevision: "{{targetRevision}}"
        plugin:
          name: avp-helm
          env:
            - name: HELM_ARGS
              value: -f values-{{deployTier}}.yaml
      syncPolicy:
        automated:
          prune: true
          selfHeal: true
        retry:
          limit: 3
          backoff:
            duration: 5s
            factor: 2
            maxDuration: 3m
        syncOptions:
          - ServerSideApply=false #-- to false

Expected behavior

ServerSideApply=false

Screenshots

image
스크린샷 2024-03-10 오후 11 55 25
image

Version

Argo Rollout Helm Chart v2.34.3

Logs

All log levels are info


Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

@kingbj940429 kingbj940429 added the bug Something isn't working label Mar 10, 2024
@jebbers-lq
Copy link

My org is also experiencing this issue. We disabled ServerSideApply in our cluster as a successful workaround for the time-being. But we'd really prefer to have the option of using ServerSideApply in the future.

@andrewjamesbrown
Copy link

We're also experiencing this, when managing rollouts via ArgoCD. If we use kubectl apply -f rollout.yaml, then change the image tag and finally kubectl apply -f rollout.yaml --server-side, rollouts work as intended. It looks like this is specific to how ArgoCD is managing server-side apply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants