Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

argocd events don't show app sync revision for multi-source apps #18169

Closed
gdsoumya opened this issue May 10, 2024 · 2 comments · Fixed by #18189
Closed

argocd events don't show app sync revision for multi-source apps #18169

gdsoumya opened this issue May 10, 2024 · 2 comments · Fixed by #18189
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@gdsoumya
Copy link
Member

Describe the bug

When using multi source apps, the k8s event logs do not show the commit revision being synced to in the event message. Shows up as Initiated automated sync to ''

Possible issue in this part of the code which only considers desiredCommitSHA and not desiredCommitSHAsMS.

To Reproduce

  • Create a multi-source app, or even a single source app but use the sources field to declare the source.
  • Enable auto sync for the app
  • When the app auto syncs to a new revision, you should see k8s events with message Initiated automated sync to '' which is missing the revision hash.

Expected behavior

The sync revision hash should show up in the argocd events.

Version

v2.10.6

@gdsoumya gdsoumya added bug Something isn't working good first issue Good for newcomers labels May 10, 2024
@onee-only
Copy link
Contributor

Hi @gdsoumya. I would like to work on this.

How do you want the format to be when it is multi source app?
Would it be okay to just join desiredCommitSHAsMS with , ?

@gdsoumya
Copy link
Member Author

@onee-only yes comma separated values should be fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants