-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retain or sort YAML ordering of images component when using Git write-back method #502
Labels
enhancement
New feature or request
Comments
nabadger
changed the title
Retain or sort YAML ordering of images component
Retain or sort YAML ordering of images component when using Git write-back method
Dec 12, 2022
jtdoepke
added a commit
to jtdoepke/argocd-image-updater
that referenced
this issue
Jan 9, 2024
This commit causes argocd-image-updater to preserve the order of fields in the kustomization.yaml file when updating the image(s). Doing so will minimize git diffs in the case that other tools also edit the kustomization.yaml file. Fixes argoproj-labs#502
jtdoepke
added a commit
to jtdoepke/argocd-image-updater
that referenced
this issue
Jan 9, 2024
This commit causes argocd-image-updater to preserve the order of fields in the kustomization.yaml file when updating the image(s). Doing so will minimize git diffs in the case that other tools also edit the kustomization.yaml file. Fixes argoproj-labs#502
jtdoepke
added a commit
to jtdoepke/argocd-image-updater
that referenced
this issue
Jan 25, 2024
This commit causes argocd-image-updater to preserve the order of fields in the kustomization.yaml file when updating the image(s). Doing so will minimize git diffs in the case that other tools also edit the kustomization.yaml file. Fixes argoproj-labs#502
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
When the Image Updater updates kustomiztion.yaml file it does not sort the
image
component for new entries (nor retain existing formatting).vs (say via the use of
kustomize
)Describe the solution you'd like
I would like the ordering to be sorted, or to retain the existing formatting.
Additional context
This is useful for us because we perform
git diff
comparisons (golden-tests) as part of our CI on our rendered manifests. Because argocd-image-updater changes the ordering, we frequently hit failed pipelines.The text was updated successfully, but these errors were encountered: