-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RolloutManager should create a ServiceMonitor for users with ServiceMonitor support #29
Labels
enhancement
New feature or request
Comments
Gerald notes that the following ServiceMonitor worked for him: apiVersion: monitoring.coreos.com/v1
kind: ServiceMonitor
metadata:
name: argo-rollouts-metrics
spec:
endpoints:
- port: metrics
selector:
matchLabels:
app.kubernetes.io/name: argo-rollouts-metrics Siddhesh notes that this can be used for reference: |
jgwest
changed the title
RolloutManager should create a ServiceMonitor for users on OpenShift
RolloutManager should create a ServiceMonitor for users with ServiceMonitor support
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
RolloutManager controller needs to create a ServiceMonitor so that metrics from Rollouts will automatically included in Prometheus gathered metrics, including in OpenShift monitoring (for OpenShift users)
Why is this important?
Scenarios
(Originally a feature request from https://issues.redhat.com/browse/GITOPS-3271)
Work Criteria
RolloutsManager
CR is reconciled, it should create the corresponding ServiceMonitor CRThis should only occur when we detect that the cluster is an OpenShift clusterFor example, by checking the API version or looking for an OpenShift-only CR (e.g.Routes
)The text was updated successfully, but these errors were encountered: