Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

afterSaveHandleTags not setting slug generator for $fields["bulk_tags"] when containing chinese characters in tags #2505

Open
hubo502 opened this issue Feb 28, 2024 · 0 comments
Labels
impact: low a minor issue for some people type: bug Something isn't working

Comments

@hubo502
Copy link

hubo502 commented Feb 28, 2024

Description

tag
when bulk update medias tags with A17\Twill\Http\Controllers\Admin\MediaLibraryController->bulkUpdate, afterSaveHandleTags in HandleTags trait not checking if $fields['bulk_tags'] contains Chinese characters, so it does not setting slug generator properly.

Expected result

if $fields['bulk_tags'] contains Chinese characters,$object should setSlugGenerator like handing $fields['tags'].

Actual result

tag2
table twill_tags creates duplicate tag(same name but empty in slug column)

Versions

Twill:3.1.0

@ifox ifox added type: bug Something isn't working impact: low a minor issue for some people labels May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact: low a minor issue for some people type: bug Something isn't working
Projects
Status: Next
Development

No branches or pull requests

2 participants