Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable heading extension if it's not in the toolbar #2511

Merged
merged 1 commit into from
May 23, 2024

Conversation

Tofandel
Copy link
Contributor

@Tofandel Tofandel commented Feb 29, 2024

Description

Since tiptap still allows html based on the extensions configured, if we disallow headings we need to let the extension know as well that it shouldn't load

Fixes #2489

@AidasK
Copy link
Contributor

AidasK commented Mar 4, 2024

Wow, thank you a lot @Tofandel!

@Afting
Copy link
Contributor

Afting commented May 3, 2024

Can you merge this @Tofandel?

@ifox
Copy link
Member

ifox commented May 3, 2024

@Tofandel doesn't have merge permissions on this repository.

We're working on Twill 3.3 with Laravel 11 support and this PR and many other will be included.

@AidasK
Copy link
Contributor

AidasK commented May 4, 2024

Wow, thanks @ifox, any eta for 3.3? We are trying to decide if we should fork this project or just wait for 3.3, so eta would be super helpful for our planning.

@Tofandel
Copy link
Contributor Author

Tofandel commented May 4, 2024

I already forked it with all my PR's if you want to use my branch until then, you can override in composer with my 3.x branch

@ifox ifox merged commit 7743207 into area17:3.x May 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable HTML paste in TipTap
4 participants