Update comment #91
Open
Update comment #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 752 776 +24
=========================================
+ Hits 752 776 +24 ☔ View full report in Codecov by Sentry. |
2bndy5
force-pushed
the
update-comment
branch
2 times, most recently
from
6364a8c
to
78a9da8
Compare
|
ping @per1234 |
2bndy5
commented
Mar 26, 2024
| api_data = self.api_request( | ||
| request="repos/" + self.repository_name + "/issues/" + str(pr_number) + "/comments", | ||
| request=request_uri, | ||
| page_number=page_number, | ||
| ) | ||
|
|
||
| comments_data = api_data["json_data"] | ||
| for comment_data in comments_data: | ||
| # Check if the comment is a report for the PR's head SHA | ||
| if comment_data["body"].startswith(self.report_key_beginning + pr_head_sha): |
There was a problem hiding this comment.
The only improvement I can think of is prepending self.report_key_beginning with an HTML comment:
where as using
report_key_beginning = "<!-- arduino/report-size-deltas -->\n**Memory usage change @ "would better assure that this action doesn't attempt to alter some user's comment starting with **Memory usage change @ .
If no comment exists, then simply post a new comment. If more than 1 comment found, then delete all but last one and update the last one.
distutils has been deprecated for years; use shutil instead add unit test for `get_previous_comment()`
defaults to false for old behavior
update tests accordingly replaces `get_previous_comment()` which was almost identical to `report_exists()`
update poetry lock file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #90
Goals
What does it do?
update-commentthat defaults tofalse(for current behavior)update-commentis set totrue, the first report comment found is updated. Furthermore, if other report comments are found in the same thread, they will be deleted.Other changes
I don't have python 3.11 installed on my system any more, so I adjusted some things to work with python 3.11+ (specifically 3.11 & 3.12).
I also prefer to use a local venv for developing on python-based projects. So, I had to add some typical names used for a local venv located at repo root to
.gitignore,.flake8, and.prettierignore.I have made sure that all unit tests still pass and added one unit test for the new functionality.