Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically load libraries from depends field in library.propreties #204

Open
3 tasks done
aliphys opened this issue Nov 17, 2023 · 2 comments
Open
3 tasks done
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement

Comments

@aliphys
Copy link

aliphys commented Nov 17, 2023

Describe the request

When a library is declared in the depends field of library.properties, it is included as part of the compilation.

In other words, when the following is part of library.properties

depends=Arduino_POSIXStorage,ArduinoRS485,Arduino_USBHostMbed5

Then this should be redundent in the comple-examples.yml workflow

libraries: |
    - name: Arduino_USBHostMbed5
    - name: Arduino_POSIXStorage
    - name: ArduinoRS485

Describe the current behavior

The dependant libraries need to be defined in the compile-sketches.yml workflow, regardless of what is defined inside the library.properties file of the library.

'arduino/compile-sketches' version

latest

Additional context

Inside the IDE, when a library is declared in the depends field of library.properties and is not installed the user is prompted to install them. This prevents dependancies issues when using the library functions or examples. As shown in this screenshot provided by @jcarolinares
image

Issue checklist

  • I searched for previous requests in the issue tracker
  • I verified the feature was still missing when using the latest version
  • My request contains all necessary details
@aliphys aliphys added the type: enhancement Proposed improvement label Nov 17, 2023
@aliphys
Copy link
Author

aliphys commented Nov 17, 2023

Demonstration of this issue: arduino-libraries/Arduino_UnifiedStorage#30 (comment)

@per1234 per1234 added the topic: code Related to content of the project itself label Nov 17, 2023
@aliphys
Copy link
Author

aliphys commented Nov 18, 2023

Rough proof of concept: https://github.com/aliphys/compile-sketches/tree/addLibrary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

No branches or pull requests

2 participants