Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cli] Expose configuration API to allow embedding in other Golang projects #2555

Closed
Xayton opened this issue Feb 29, 2024 · 0 comments · Fixed by #2565
Closed

[cli] Expose configuration API to allow embedding in other Golang projects #2555

Xayton opened this issue Feb 29, 2024 · 0 comments · Fixed by #2565
Assignees
@cmaglie
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: enhancement Proposed improvement
Milestone
Arduino CLI v1.0.0

Comments

@Xayton
Copy link

Xayton commented Feb 29, 2024 •
edited by cmaglie

The package configuration, currently internal, should be exported as public API in some way to allow embedding the CLI into golang projects. The configuration package contains a singleton configuration shared among all the instances created.

A possible solution may be to allow pushing an initial configuration from the Init command and keep a different configuration for each instance. In this case, the Settings* API must be changed to operate on a given instance (currently they act on the global configuration).
@cmaglie cmaglie added this to the Arduino CLI v1.0.0 milestone Feb 29, 2024
@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Mar 1, 2024
@cmaglie cmaglie mentioned this issue Mar 4, 2024
Closed
@cmaglie cmaglie linked a pull request Apr 23, 2024 that will close this issue
[BREAKING] gRPC / golang Configuration API refactoring #2565
Merged
6 tasks
@per1234 per1234 added the conclusion: resolved Issue was resolved label May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmaglie cmaglie

Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
Arduino CLI v1.0.0
Development

Successfully merging a pull request may close this issue.

[BREAKING] gRPC / golang Configuration API refactoring cmaglie/arduino-cli
3 participants
@cmaglie @per1234 @Xayton