Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request: sign db image with cosign #205

Open
06kellyjac opened this issue Apr 19, 2022 · 4 comments · May be fixed by #230
Open

request: sign db image with cosign #205

06kellyjac opened this issue Apr 19, 2022 · 4 comments · May be fixed by #230

Comments

@06kellyjac
Copy link

For highly regulated clients there's an interest in the DB image being signed. This could be done on GHCR with cosign.

@ShubhamPalriwala
Copy link

@knqyf263 Can I work on this?

If I'm getting this correct, we sign the build artifact in our CI and push it to our Container Registry, and give our end users an option to verify the artifact they downloaded either using our public key or keyless.

Is there anything else you have in mind?

@knqyf263
Copy link
Collaborator

Sounds good!

@ShubhamPalriwala
Copy link

Hey @knqyf263, so I have worked on something similar at Kyverno and had a query.

The design system for this we followed there was to push the signature as well as the artifact (in our case, DB) in the same CR. The issue we faced there later was that the metrics(number of downloads for the package) weren't accurate anymore as cosign verifications downloaded the .sig file and affected the same.

Hence we later shifted to a separate signatures GHCR signatures

Since, in our case, until now, we are overwriting the image with the same tag on our CR, it does not populate the CR and keeps it clean.
However, a signature is generated based on the hash of the commit hence it would get really populated with the signatures.

Attaching a screenshot for an exact mockup I tried for our trivy-db on my personal GHCR package:
Screenshot_2022-07-20-00-11-13_1920x1080

As we can see. for every update and push in the CR, it generates and pushes a new sig file.

Hence, in my opinion, we should create a separate package registry, too, like trivy-db-signatures. Would like to know your thoughts on the same.

@knqyf263
Copy link
Collaborator

Nice catch. It makes sense to have another repository for signatures.

@ShubhamPalriwala ShubhamPalriwala linked a pull request Jul 20, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants