📚 Documentation: Wrong Logic For Android FCM x Messaging

[ItzNotABug]

💭 Description

The documentation here mentions using a FirebaseMessagingService for updating the push targets for messaging.

However it uses this logic -

class MessagingService : FirebaseMessagingService() {

    companion object {
        var account: Account? = null
    }

    override fun onNewToken(token: String) {
        // get token, save to sharedPreferences.
    
        // check if account is null
        if (account == null) {
            return
        }
    
        // update push target
    }
}

1. The default value is null, then never initialised (as per the documentation)
2. The check would always return true & the push target will not be updated

Note: The example repository properly manages this, however the usage of Account variable looks unrelated & incomplete on documentation.

---

Also, there is a mention of targetId which I do not think is something used by the SDK internally.
It is not saved in the SharedPreferences the first time the token is retrieved but only managed in the above mentioned Service. Also Its better to provide a small explanation about this as well.

👀 Have you spent some time to check if this issue has been raised before?

• I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

• I have read the Code of Conduct