Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The response view in split pane should be collapsable and not closable #33336

Closed
Tracked by #33333
hetunandu opened this issue May 9, 2024 · 0 comments · Fixed by #33441
Closed
Tracked by #33333

The response view in split pane should be collapsable and not closable #33336

hetunandu opened this issue May 9, 2024 · 0 comments · Fixed by #33441
Assignees
@hetunandu
Labels
IDE Navigation Issues/feature requests related to IDE navigation, and context switching New Developers Pod Issues that new developers face while exploring the IDE Task A simple Todo

Comments

@hetunandu
Copy link
Member

hetunandu commented May 9, 2024 •
edited

Split screen has a small part of the debugger apart from the whole full screen version. To avoid confusions, we will not let the users close the debugger pane when in split screen
@hetunandu hetunandu mentioned this issue May 9, 2024
Closed
@Nikhil-Nandagopal Nikhil-Nandagopal added the Task A simple Todo label May 9, 2024
@hetunandu hetunandu added IDE Navigation Issues/feature requests related to IDE navigation, and context switching IDE Pod https://app.zenhub.com/workspaces/new-developers-pod-60507ad1d4b98d00150a2858/board labels May 9, 2024
@hetunandu hetunandu self-assigned this May 9, 2024
@github-actions github-actions bot added New Developers Pod Issues that new developers face while exploring the IDE and removed IDE Pod https://app.zenhub.com/workspaces/new-developers-pod-60507ad1d4b98d00150a2858/board labels May 9, 2024
@hetunandu hetunandu mentioned this issue May 15, 2024
Merged
2 tasks
hetunandu added a commit that referenced this issue May 22, 2024
@hetunandu
feat: Collapsible Bottom View (#33441)
dbb07b8 
## Description

- Creates a new IDE component for `BottomView` that can be either
collapsed or closed.
- Creates a different view for `EntityTabs` when it is collapsed
- Start using the collapsed version for Entity Responses (Query / API /
JS)


Fixes #33333 
Fixes #33336 
Fixes #31402

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]
> 🔴 🔴 🔴 Some tests have failed.
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9175565108>
> Commit: 8f3b96e
> Cypress dashboard: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9175565108&attempt=1&selectiontype=test&testsstatus=failed&specsstatus=fail"
target="_blank"> Click here!</a>
> The following are new failures, please fix them before merging the PR:
<ol>
>
<li>cypress/e2e/Regression/ClientSide/Binding/Button_Text_WithRecaptcha_spec.js
>
<li>cypress/e2e/Regression/ClientSide/Widgets/Others/IconButton_2_spec.ts
</ol>
> To know the list of identified flaky tests - <a
href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master"
target="_blank">Refer here</a>

<!-- end of auto-generated comment: Cypress test results  -->

















## Communication
Should the DevRel and Marketing teams inform users about this change?
- [x] Yes
- [ ] No
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hetunandu hetunandu

Labels
IDE Navigation Issues/feature requests related to IDE navigation, and context switching New Developers Pod Issues that new developers face while exploring the IDE Task A simple Todo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Collapsible Bottom View appsmithorg/appsmith
2 participants
@Nikhil-Nandagopal @hetunandu