-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Ember Global deprecation #552
Labels
Comments
@unflxw are you still actively working on this? If not, can you update the user who reported the issue about the latest status? You move it to the backlog if we're going to revisit this later. |
@tombruijn Done and done. 👍 #546 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From #546:
Accessing the
window.Ember
global variable raises a deprecation warning in version 3.27, and it is not possible in version 4.0. Our Ember integration exposes aninstallErrorHandler
function, which takes anAppsignal
instance and anEmber
instance as arguments; if no Ember instance is provided, it useswindow.Ember
as a default value.As a workaround for this issue, as documented, users can manually import Ember and pass it as a second argument:
However, our integration should be updated to import Ember to use it as the default value for its second argument.
The text was updated successfully, but these errors were encountered: