Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] NULL Pointer Dereference in mask_cidr6 at cidr.c:228 #824

Closed
TimChan2001 opened this issue Sep 13, 2023 · 2 comments · Fixed by #843
Closed

[Bug] NULL Pointer Dereference in mask_cidr6 at cidr.c:228 #824

TimChan2001 opened this issue Sep 13, 2023 · 2 comments · Fixed by #843
Assignees
@fklassen
Labels
bug
Projects
4.5

Comments

@TimChan2001
Copy link

Describe the bug
There is a NULL Pointer Dereference in mask_cidr6 when the user passes empty pseudo-NAT string to tcprewrite with option --pnat

To Reproduce
Steps to reproduce the behavior:

  1. export CC=clang && export CFLAGS="-fsanitize=address -g"
  2. ./autogen.sh && ./configure --disable-shared --disable-local-libopts && make clean && make -j8
  3. ./src/tcprewrite -o /dev/null -i POC --pnat=""
    The POC file could be downloaded in POC

Expected behavior
Program crashes with SEGV.

==2629735==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000000 (pc 0x56108e9eb575 bp 0x7fff0fde5190 sp 0x7fff0fde5100 T0)
==2629735==The signal is caused by a READ memory access.
==2629735==Hint: address points to the zero page.
    #0 0x56108e9eb575 in mask_cidr6 /home/yiyang/tcpreplay-4.4.4/src/common/cidr.c:228:9
    #1 0x56108e9eb2ad in parse_cidr /home/yiyang/tcpreplay-4.4.4/src/common/cidr.c:252:5
    #2 0x56108e9ec836 in parse_cidr_map /home/yiyang/tcpreplay-4.4.4/src/common/cidr.c:371:10
    #3 0x56108e9bd98a in tcpedit_post_args /home/yiyang/tcpreplay-4.4.4/src/tcpedit/parse_args.c:54:22
    #4 0x56108e9b678f in main /home/yiyang/tcpreplay-4.4.4/src/tcprewrite.c:84:13
    #5 0x7f6cb96bed8f in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
    #6 0x7f6cb96bee3f in __libc_start_main csu/../csu/libc-start.c:392:3
    #7 0x56108e8f6544 in _start (/home/yiyang/tcpreplay-4.4.4/src/tcprewrite+0x38544) (BuildId: be72a8c23dd0721673aaa687b6258865600acadf)

AddressSanitizer can not provide additional info.
SUMMARY: AddressSanitizer: SEGV /home/yiyang/tcpreplay-4.4.4/src/common/cidr.c:228:9 in mask_cidr6
==2629735==ABORTING

System (please complete the following information):

  • OS: Ubuntu
  • OS version: 22.04, 64 bit
  • Tcpreplay Version: 4.4.4
GabrielGanne added a commit to GabrielGanne/tcpreplay that referenced this issue Jan 21, 2024
@GabrielGanne
add check for empty cidr
236ce27 
This causes tcprewrite to exit with an error instead of crashing.

Fixes: appneta#824
@GabrielGanne GabrielGanne mentioned this issue Jan 21, 2024
Merged
GabrielGanne added a commit to GabrielGanne/tcpreplay that referenced this issue Jan 21, 2024
@GabrielGanne
add check for empty cidr
a0b6d84 
This causes tcprewrite to exit with an error instead of crashing.

Fixes: appneta#824
Signed-off-by: Gabriel Ganne <[email protected]>
@fklassen
Copy link
Member

fklassen commented Jun 1, 2024

Reopening as this is not yet tested and merged.

@fklassen fklassen reopened this Jun 1, 2024
@fklassen fklassen self-assigned this Jun 1, 2024
@fklassen fklassen added the bug label Jun 1, 2024
@fklassen fklassen added this to To do in 4.5 via automation Jun 1, 2024
fklassen added a commit that referenced this issue Jun 1, 2024
@fklassen
Bug #824 PR# 843: add check empty CIDR
ef3df29
@fklassen
Copy link
Member

fklassen commented Jun 1, 2024

fixed in PRs #843 and #860

@fklassen fklassen closed this as completed Jun 1, 2024
4.5 automation moved this from To do to Done Jun 1, 2024
fklassen added a commit that referenced this issue Jun 1, 2024
@fklassen
Merge pull request #860 from appneta/Bug_824_PR_843_empty_CIDR_check_…
36501b0 
…staging

Bug #824 and PR #843: check for empty CIDR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fklassen fklassen

Labels
bug
Projects
4.5
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add check for empty cidr GabrielGanne/tcpreplay
2 participants
@fklassen @TimChan2001