Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from legacy FCM HTTP API to HTTP v1 API #550

Closed
ghost opened this issue Nov 24, 2020 · 24 comments
Closed

Migrate from legacy FCM HTTP API to HTTP v1 API #550

ghost opened this issue Nov 24, 2020 · 24 comments
Assignees

Comments

@ghost
Copy link

ghost commented Nov 24, 2020

This project's dependency github.com/appleboy/go-fcm uses legacy FCM HTTP API.
Are there any plans to migrate it to the v1 API as recommended by Firebase documentation? Or maybe
integrate Firebase Admin SDK instead of using raw HTTP API.

Also, how can I pass TitleLocArgs and BodyLocArgs values as array of strings? In the dependency mentioned above
these values are defined as plain strings whereas FCM documentation specifies them as array of strings .
When I make a request with TitleLocArgs I get an error Error Message: unknown error type. However when I make same request connecting directly to FCM server everything works fine.

@giovanni-orciuolo
Copy link

+1

@cdivita
Copy link

cdivita commented Dec 5, 2022

+1 also for me

@IlyaGulya
Copy link

IlyaGulya commented Jun 21, 2023

Hello!
Today Google announced that FCM Legacy HTTP API will be removed on June 20, 2024.
I think now this ticket should get a bit more attention 🙂
https://firebase.google.com/docs/cloud-messaging/http-server-ref

@appleboy
Copy link
Owner

@IlyaGulya I will take it.

@pvincendeau
Copy link

pvincendeau commented Jul 20, 2023

@IlyaGulya I will take it.

Hello @appleboy.
Do you have any idea of a time schedule for the release of a new version using FCM HTTP v1 API instead of the legacy one please ?
Thanks a lot in advance !

@c0olix
Copy link

c0olix commented Nov 16, 2023

Hey there, I found your promising notification service yesterday. I would really love to use this, but this issue is keeping me from using it. Any chance to get an estimation, when Firebase Cloud Messaging API (V1) is implemented?

Thanks

@c0olix
Copy link

c0olix commented Feb 8, 2024

Bump

@sankethkini
Copy link

@IlyaGulya I will take it.

@appleboy any estimation on by when this will get implemented?

@appleboy
Copy link
Owner

appleboy commented Mar 3, 2024

Hey, sorry about that. I'm planning to kick off the API transition this month, and hopefully, by next month, there'll be a version ready for everyone to test out.

@obuzyig
Copy link

obuzyig commented Mar 14, 2024

Dear @appleboy,

Thank you for your amazing effort.

I have checked out potential authorization methods on FCM HTTP v1 API Documentation and wondered if it is possible to maintain the multi-tenancy on the new approach.

Regarding the previous API, the "api_key" input helps to send notifications to multiple applications. Selecting different "JSON" files, including project-id values, to authorize could be a valuable capability for somehow maintaining multi-tenancy.

@appleboy
Copy link
Owner

@obuzyig

Thank you for reaching out and for your kind words regarding our efforts.

I'm delighted to inform you that we are fully committed to supporting multi-tenancy on the FCM HTTP v1 API platform. Your feedback regarding the potential authorization methods and the importance of maintaining multi-tenancy is greatly appreciated.

@sankethkini
Copy link

#550 (comment)

@obuzyig I am aware of only one feasible method for authorization i.e, using service-account.json files. Are you aware of any other methods as such?

@obuzyig
Copy link

obuzyig commented Mar 26, 2024

#550 (comment)

@obuzyig I am aware of only one feasible method for authorization i.e, using service-account.json files. Are you aware of any other methods as such?

@sankethkini I think FCM provides the Application Default Credentials option for applications that work on a Google-related platform or infrastructure. I do not have any other generic solutions for covering other applications.

@petenickless
Copy link

Hey, sorry about that. I'm planning to kick off the API transition this month, and hopefully, by next month, there'll be a version ready for everyone to test out.

Hey @appleboy - just wondering if it's possible to get an update on progress with this. Do you think the upgrade will be ready to be used in production before the legacy HTTP API is switched off in June?

Thanks in advance 👍

@hilariocoelho
Copy link
Contributor

Hey, sorry about that. I'm planning to kick off the API transition this month, and hopefully, by next month, there'll be a version ready for everyone to test out.

Hello @appleboy . Are there any news regarding this subject?

@appleboy
Copy link
Owner

@hilariocoelho

I am continuing with the development and expect to have a release ready for testing by everyone on 05/10 Taiwan time. Sorry for the late reply.

@appleboy
Copy link
Owner

Hi All,

Update on current status:

I'm currently trying to resolve the upgrade issue at appleboy/go-fcm#38. Once the package resolves this, I will proceed with the upgrade here. I apologize for the delay in scheduling, and I will keep everyone posted on the progress here."

@appleboy
Copy link
Owner

Hi All,

Update on current status:

I already update the dependency package go-fcm. Next, I plan to update the Gorush. Maybe next week I can offer the new testing version.

appleboy/go-fcm#38 (comment)

@pvincendeau
Copy link

Hello @appleboy

Do you have any estimation on when a final release of gorush implementing the new FCM integration will be available ? The legacy API will be discontinued in less than 3 weeks and we need to know if we have to adjust our plans and look for an alternative or stick with your great solution.

Thanks in advance

@appleboy
Copy link
Owner

appleboy commented Jun 3, 2024

@pvincendeau I will release the new version this week.

@pvincendeau
Copy link

pvincendeau commented Jun 7, 2024

Hi @appleboy
Do you have any news on the final release date ? I was hoping that the version will be available today as you told me ealier that it would be available this week. Our application relies on gorush to send push notification and it is one of our major feature. We really need to update as soon as possible and the deadline is now less than two weeks away.
Thanks in advance

@appleboy
Copy link
Owner

appleboy commented Jun 7, 2024

@petenickless Can you give the two days? I will release the first version on Sunday (06/09 UTC+8:00).

@appleboy
Copy link
Owner

appleboy commented Jun 9, 2024

@petenickless @IlyaGulya @hilariocoelho @cdivita I released the v1.18.0 version. Please help to try it out. https://github.com/appleboy/gorush/releases/tag/v1.18.0

@appleboy appleboy closed this as completed Jun 9, 2024
@appleboy
Copy link
Owner

appleboy commented Jun 9, 2024

Please feel free to open a new issue if anyone has any further questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants