Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable "Allow merge commits" and "Allow rebase merging" in GitHub UI #467

Open
translatenix opened this issue Apr 30, 2024 · 3 comments
Open

Comments

@translatenix
Copy link
Contributor

Unsquashed PRs with poor commit messages keep appearing on the main branch. To prevent such oversights in the future, I propose to disable "Allow merge commits" and "Allow rebase merging" in GitHub settings. Note that this only affects the GitHub UI.

@bioball
Copy link
Contributor

bioball commented Apr 30, 2024

How would we rebase-merge if it's disabled in the UI? Would gh work if we intentionally wanted to rebase-merge?

@translatenix
Copy link
Contributor Author

I haven't tried, but I'd expect gh to be unaffected. Plain git is definitely unaffected.

@translatenix
Copy link
Contributor Author

Correction: gh pr merge does honor these settings. So you'd need to use plain git to intentionally do a rebase-merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants