New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
package resolve does not save packages in cache #374
Comments
My understanding is that packages are always cached unless |
Instead of adding a |
Is there a benefit in keeping resolution and download decoupled? That was the idea behind |
We did discuss it. When using |
It’s about actively avoiding resolution, not actively avoiding download. If all I want is to download, I should never have to worry about |
Avoiding resolution is fair enough. We were debating whether |
Good point about If we do want to lean on this being the method for "I want to download all my project dependencies", we can maybe add a flag for "don't update already-resolved dependencies" in the future, if "latest" becomes a thing. BTW: "I want to download all my dependencies" can also be a shell script: cat PklProject.deps.json \
| jq -c -r '.resolvedDependencies[] | select(.type == "remote") | (.uri[7:] + "::" + .checksums.sha256)' \
| xargs -I {} pkl download-package {} |
I guess I don’t mind if My gut feeling is that there should be an easy way to download all package dependencies without resolving. If the |
The resolve command does need to download in order to build the resolved dependency list. Since it's already downloading, it's actually a little strange that it's not writing them to the cache dir.
Fair; I can definitely see a mode in |
Oh I thought that |
Right now resolving packages doesn't store packages in the cache.
This is in some situations problematic because "fully offline use" is not possible with the current implementation.
Except of the fact that it is also desired to cache packages to avoid unnecessary API calls.
Found out via this discussion.
See also this comment: #346 (reply in thread)
The text was updated successfully, but these errors were encountered: