Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmark Trace.cpp:SuppressionMap #11421

Open
xis19 opened this issue May 22, 2024 · 0 comments
Open

Benchmark Trace.cpp:SuppressionMap #11421

xis19 opened this issue May 22, 2024 · 0 comments

Comments

@xis19
Copy link
Collaborator

xis19 commented May 22, 2024

Trace.cpp:SuppressionMap would (1) create a copy of the TraceEvent type string (2) Store the string inside the std::map data structure.

Considering the frequency of using TraceEvent it might be interesting to see:

  1. It is possible that SuppressionMap will only create a copy of the TraceEvent::type when it is unknown.
  2. Try std::unordered_map or some other custom implementation?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xis19