Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: Add searched element to popup window #1241

Closed
Dor-bl opened this issue Dec 10, 2023 · 5 comments · Fixed by #1485
Closed

feature request: Add searched element to popup window #1241

Dor-bl opened this issue Dec 10, 2023 · 5 comments · Fixed by #1485
Labels
enhancement New feature or request

Comments

@Dor-bl
Copy link

Dor-bl commented Dec 10, 2023

Current Behavior

Currently when searching for an element, in case the element is not found the user see a general message saying: "Could not find any elements"

Suggested Solution

the popup should include the element we searched for as well.
i.e. Could not find any elements matching the below criteria: {Element selector value}"
image

Additional Information

This will help users when they are working closely with dev teams to add unique identifiers to their app, so they can show them what is missing for what value of selector used.

@Dor-bl Dor-bl added the enhancement New feature or request label Dec 10, 2023
@VineethG-Protean
Copy link

image
Something like this?

@Dor-bl
Copy link
Author

Dor-bl commented Apr 29, 2024

I believe so.
Maybe also include the selector type

@sudharsan-selvaraj
Copy link
Contributor

@Dor-bl How about this one? Any thoughts? If it looks good, i shall raise a PR with the changes.

Screenshot 2024-06-04 at 7 00 51 AM

@Dor-bl
Copy link
Author

Dor-bl commented Jun 4, 2024

LGTM 🍻

@sudharsan-selvaraj
Copy link
Contributor

@Dor-bl Cool. Opened a PR with the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants