Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[✅ASSIGNED] Persistence React/Redux & Refactoring #18

Open
app-generator opened this issue Jul 17, 2023 · 2 comments
Open

[✅ASSIGNED] Persistence React/Redux & Refactoring #18

app-generator opened this issue Jul 17, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested

Comments

@app-generator
Copy link
Owner

app-generator commented Jul 17, 2023

STATUS: ASSIGNED to @yurec133


Context

The codebase pattern might be improved if the persistence is managed by React/Redux instead of localStorage (the current solution)

@yurec133 Please take into account this request.

Before updating the code, please explain the advantages of such integration.

Ty!

@app-generator app-generator added enhancement New feature or request question Further information is requested help wanted Extra attention is needed labels Jul 17, 2023
@app-generator app-generator changed the title [DEBATE] Data Persistence React/Redux [ASSIGNED] Data Persistence React/Redux Jul 17, 2023
@app-generator app-generator changed the title [ASSIGNED] Data Persistence React/Redux [ASSIGNED] Persistence React/Redux & Refactoring Jul 17, 2023
@app-generator app-generator changed the title [ASSIGNED] Persistence React/Redux & Refactoring [✅ASSIGNED] Persistence React/Redux & Refactoring Jul 17, 2023
@yurec133
Copy link
Collaborator

When we use redux, we will have the state of all entities that are easy to debug. I propose such an architectural approach, when we add an item using onDrop, we bring this element to redux and in redux we change it as needed, then we take it from redux and bring it to the DOM, when we press the save button, we take the data from redux and store it in localStorage and then we take data from localStorage again and enter it in redux state to have up-to-date data

@app-generator
Copy link
Owner Author

Hello @yurec133

All the above arguments are noted. Let's proceed with the development using redux-integration as a test branch:

https://github.com/app-generator/rocket-builder/tree/redux-integration

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants