Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu logic requiring a registered non-admin user is confusing #7

Open
rsyring opened this issue Jun 26, 2023 · 3 comments
Open

Menu logic requiring a registered non-admin user is confusing #7

rsyring opened this issue Jun 26, 2023 · 3 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@rsyring
Copy link

rsyring commented Jun 26, 2023

After following readme setup instructions and logging in as an admin user I only get a minimal side menu:

image

That's incredibly confusing since there are supposed to be a lot of example pages. Attempts to load the URLs for those pages manually work when I'm admin but get redirected to login when I'm not logged in. Turns out the full menu only show up for registered non-admin users. That's...really unexpected.

@rsyring rsyring changed the title Menu logic is messed up Menu logic requiring a registered non-admin user is confusing Jun 26, 2023
@app-generator
Copy link
Owner

Hello @rsyring

Based on your feedback, we've released a new version with the LOGIN decorator removed from the routes.

Regarding the menu items, this can be easily customized by overwriting the menu-list.html

If helps, we can share a repo with you and assist directly in the code.

Let us know your progress.

@app-generator app-generator self-assigned this Jun 27, 2023
@app-generator app-generator added the help wanted Extra attention is needed label Jun 27, 2023
@rsyring
Copy link
Author

rsyring commented Jun 28, 2023

I'll checkout the new version.

Regarding the menu items, this can be easily customized by overwriting the menu-list.html

I understand that. My point is that by showing a very basic side navigation when a superuser is logged in it hinders discoverability of all the example/demo content available in the app. Why limit that? Why make it hard to find?

IMO, it would be better DX to just put make the full menu static and show it to all users regardless of authentication or permissions level.

@app-generator
Copy link
Owner

Hello @rsyring

The current sidebar structure (filtered by the user role) was implemented based on the feedback collected from the community.
For sure can be improved but we always try to follow the community trends.

In your case, let us know the specific changes you need and we will assist directly with the code.

If sounds good, please add app-generator to your repository so we can apply the changes.

Thank you for your feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants