Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php-fpm is not installed when using 'gitpodlatest' for the PHP version in starter.ini #203

Open
apolopena opened this issue Mar 1, 2022 · 1 comment
Assignees
Labels
bug Something isn't working passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main

Comments

@apolopena
Copy link
Owner

apolopena commented Mar 1, 2022

Describe the bug

When using the existing installation of PHP in gitpod/workspace-mysql, php-fpm is not installed so PHP does not work with nginx out of the box. This breaks the demo flow when nginx is the default server (which currently is the default in starter.ini).

Screenshots

image

Steps to reproduce

  1. ensure docker image layer cache is busted
  2. run a gitpod-laravel-starter with 'gitpodlatest' set for the PHP version in starter.ini

Expected behavior

Ideally php-fpm would be installed as part of gitpod/workspace-mysql. There is a question there in a PR that rasies this thought.

At a minimum php-fpm must be installed in php.sh when the existing Gitpod installation of PHP is left as-is.
This will of course need to be removed if Gitpod decides to includes php-fpm in gitpod/workspace-mysql
We could sniff for the php-fpm installation and act accordingly but I would rather not introduce that complexity.

Additional information

I decided to go with sniffing out the php-fpm install and dynamically installing it if it wasn't already installed.

@apolopena apolopena added the bug Something isn't working label Mar 1, 2022
@apolopena apolopena self-assigned this Mar 1, 2022
apolopena added a commit that referenced this issue Mar 1, 2022
@apolopena apolopena added in-development Bug or feature is currently being worked on in-dev-qa passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main and removed in-development Bug or feature is currently being worked on in-dev-qa labels Mar 1, 2022
@apolopena
Copy link
Owner Author

depends on #204

@apolopena apolopena added this to the v1.6 release 🚀 milestone Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main
Projects
None yet
Development

No branches or pull requests

1 participant