Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<p> tag is not recognized in list #45

Open
spacewander opened this issue Apr 10, 2020 · 2 comments
Open

<p> tag is not recognized in list #45

spacewander opened this issue Apr 10, 2020 · 2 comments
Assignees
Labels
bug Something isn't working
Projects

Comments

@spacewander
Copy link
Contributor

When converting text like this:

## EXAMPLES

  * Updating AUTHORS file:

    $ git authors

  * Listing authors:

    $ git authors --list

ronn-ng complains warn: unrecognized inline tag: ["p"] and omits the inner text block.

The text is from markdown file https://github.com/tj/git-extras/blob/master/man/git-authors.md

@deivid-rodriguez
Copy link
Contributor

Not sure if this will be useful, but I got rid of a similar issue while experimenting with ronn-ng here:

rubygems/bundler#7265

Your markup, unlike in my case, looks just fine to me though.

@apjanke apjanke added the bug Something isn't working label Apr 11, 2020
@apjanke apjanke added this to Needs triage in ronn-ng via automation Apr 11, 2020
@apjanke apjanke moved this from Needs triage to High priority in ronn-ng Apr 11, 2020
@apjanke
Copy link
Owner

apjanke commented Apr 11, 2020

Your markup looks fine to me too. It's a bug that ronn is not handling it.

I think what's happening is that the list items processor is expecting only inline tags inside the list item content. p is a block tag, not an inline tag. The list item handling probably needs to be expanded to support block tags.

@apjanke apjanke self-assigned this Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: High priority
ronn-ng
  
High priority
Development

No branches or pull requests

3 participants