fix: cluster creation error when serviceVersion is not set in ComponentDefinition #7415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjc7373
requested review from
nayutah,
ldming,
heng4fun,
free6om,
wangyelei,
Y-Rookie and
weicao
as code owners
leon-inf
approved these changes
May 23, 2024
weicao
approved these changes
May 23, 2024
cjc7373
force-pushed
the
bugfix/empty-serviceversion-in-compdef
branch
from
aef8451
to
1cabbba
Compare
leon-inf
approved these changes
May 23, 2024
|
/approve |
apecloud-bot
approved these changes
May 23, 2024
|
/approve |
apecloud-bot
approved these changes
May 27, 2024
|
/cherry-pick release-0.9 |
|
🤖 says: cherry pick action finished successfully 🎉! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7414, not sure if this is a right fix. @leon-inf please take a look