Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sql_lab]Add back description column to saved queries #12431

Closed
eschutho opened this issue Jan 12, 2021 · 12 comments · Fixed by #28349
Closed

[sql_lab]Add back description column to saved queries #12431

eschutho opened this issue Jan 12, 2021 · 12 comments · Fixed by #28349
Assignees
Labels
assigned:preset Assigned to the Preset team good first issue Good first issues for new contributors sqllab:saved_queries

Comments

@eschutho
Copy link
Member

Is your feature request related to a problem? Please describe.
The description column was removed from the saved queries. We would like to add it back.
Styling TBD

Describe the solution you'd like
Show the description of the saved query if it exists on the saved queries page.

Describe alternatives you've considered
Not showing the description, but it seems helpful.

Additional context
Banners_and_Alerts_and__DEV__Superset

@eschutho
Copy link
Member Author

eschutho commented Jan 12, 2021

@yousoph @Steejay can you help with designs? Thanks!

@junlincc junlincc added assigned:preset Assigned to the Preset team and removed preset-io labels Jan 12, 2021
@junlincc junlincc changed the title Add back description column to saved queries [sql_lab]Add back description column to saved queries Jan 12, 2021
@Steejay
Copy link

Steejay commented Jan 12, 2021

@eschutho @yousoph yes! ill make a design ticket for this and coordinate w Sophie

@eschutho eschutho added the good first issue Good first issues for new contributors label Jun 14, 2022
@mtsadler-branch
Copy link

+1

@yousoph
Copy link
Member

yousoph commented Nov 10, 2022

Let's add the column as the second column from the left (right after name)

@khallon would love to be pinged when a PR is ready to take a look and give potential design feedback/tweaks :) Thanks!

@rusackas
Copy link
Member

Anyone still planning to go after this, or should we close it as stale?

@imancrsrk
Copy link
Contributor

@rusackas I've never contributed to OSS. I would like to take a stab at this one if nobody is actively working on it.

@rusackas
Copy link
Member

@imancrsrk go for it! In your eventual PR description, just add "Fixes #12431" to auto-close this issue upon merge. :)

@imancrsrk
Copy link
Contributor

@rusackas I've raised PR - #28349. I see that 2 checks have passed but another 18 are waiting to be reported, hope this is ok. Hope to get a review soon!

Thanks :-)

imancrsrk pushed a commit to imancrsrk/superset that referenced this issue May 6, 2024
@rusackas
Copy link
Member

rusackas commented May 6, 2024

Looks like the PR is super close... I just had a question about he renaming of the Name filter to Search, since it introduces an inconsistency between list views that may or may not be warranted.

@imancrsrk
Copy link
Contributor

Looks like the PR is super close... I just had a question about he renaming of the Name filter to Search, since it introduces an inconsistency between list views that may or may not be warranted.

I replied back. The search filter is already searching all text columns, name, description, etc. so @nytai suggested that we make the filter name more general, search

@imancrsrk
Copy link
Contributor

@rusackas I've added the tooltip description.
#28349 (comment)

@imancrsrk
Copy link
Contributor

@rusackas I had sent out a change that aligns the tooltip better. Hope you can take a look at it today and let me know if anything else is needed :-)

imancrsrk pushed a commit to imancrsrk/superset that referenced this issue May 10, 2024
imancrsrk pushed a commit to imancrsrk/superset that referenced this issue May 10, 2024
rusackas pushed a commit that referenced this issue May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned:preset Assigned to the Preset team good first issue Good first issues for new contributors sqllab:saved_queries
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants