New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sql_lab]Add back description column to saved queries #12431
Comments
+1 |
Let's add the column as the second column from the left (right after name) @khallon would love to be pinged when a PR is ready to take a look and give potential design feedback/tweaks :) Thanks! |
Anyone still planning to go after this, or should we close it as stale? |
@rusackas I've never contributed to OSS. I would like to take a stab at this one if nobody is actively working on it. |
@imancrsrk go for it! In your eventual PR description, just add "Fixes #12431" to auto-close this issue upon merge. :) |
Looks like the PR is super close... I just had a question about he renaming of the Name filter to Search, since it introduces an inconsistency between list views that may or may not be warranted. |
I replied back. The search filter is already searching all text columns, name, description, etc. so @nytai suggested that we make the filter name more general, |
@rusackas I've added the tooltip description. |
@rusackas I had sent out a change that aligns the tooltip better. Hope you can take a look at it today and let me know if anything else is needed :-) |
Co-authored-by: SRK <[email protected]> Co-authored-by: ʈᵃᵢ <[email protected]>
Is your feature request related to a problem? Please describe.
The description column was removed from the saved queries. We would like to add it back.
Styling TBD
Describe the solution you'd like
Show the description of the saved query if it exists on the saved queries page.
Describe alternatives you've considered
Not showing the description, but it seems helpful.
Additional context
The text was updated successfully, but these errors were encountered: