Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

superset_text.yml not loading the PREFERRED_DATABASES icons #28325

Open
geanttechnology opened this issue May 2, 2024 · 1 comment
Open

superset_text.yml not loading the PREFERRED_DATABASES icons #28325

geanttechnology opened this issue May 2, 2024 · 1 comment

Comments

@geanttechnology
Copy link

Bug description

I have created a file named superset_text.yml and appended the following DB drivers and respective icons:

DB_IMAGES:
  postgresql: "/static/assets/images/postgresql.png"
  oracle: "/static/assets/images/oracle.png"
  mysql: "/static/assets/images/mariadb.png"
  vertica: "/static/assets/images/vertica.png"
  redshift: "/static/assets/images/redshift.png"
  databricks: "/static/assets/images/databricks.png"
  clickhouse: "/static/assets/images/clickhouse.png"
  google-biquery: "/static/assets/images/google-biquery.png"

But it is not being picked up by the Databases listed in PREFERRED_DATABASES in the config file

How to reproduce the bug

Add the following in the config file:

PREFERRED_DATABASES: list[str] = [
    "PostgreSQL",
    "Oracle",
    "MySQL",
    "Vertica",
    "AWS Redshift",
    "Databricks",
    "ClickHouse",
    "Google BigQuery",
    # etc.
]

Then create a file named superset_text.yml and append the following code snippet:

DB_IMAGES:
  postgresql: "/static/assets/images/postgresql.png"
  oracle: "/static/assets/images/oracle.png"
  mysql: "/static/assets/images/mariadb.png"
  vertica: "/static/assets/images/vertica.png"
  redshift: "/static/assets/images/redshift.png"
  databricks: "/static/assets/images/databricks.png"
  clickhouse: "/static/assets/images/clickhouse.png"
  google-biquery: "/static/assets/images/google-biquery.png"
````

Then go to the Superset UI and try to add and new database source. The preferred databases should be listed but they do not have the right icons.

### Screenshots/recordings

_No response_

### Superset version

master / latest-dev

### Python version

3.9

### Node version

16

### Browser

Chrome

### Additional context

_No response_

### Checklist

- [X] I have searched Superset docs and Slack and didn't find a solution to my problem.
- [X] I have searched the GitHub issue tracker and didn't find a similar bug report.
- [X] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.
@hainenber
Copy link
Contributor

hainenber commented May 5, 2024

This feature seems to be not implemented yet and is only in placeholder mode

return require('../../../superset_text') || {};

It'd be an interesting feature to implement but I don't know the context behind its incompleteness. Wonder if any PMC could shed some lights ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants