Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error is not precise when 2 database connexions use the same display name #28257

Open
3 tasks done
xavier-GitHub76 opened this issue Apr 29, 2024 · 2 comments
Open
3 tasks done

Comments

@xavier-GitHub76
Copy link
Contributor

Bug description

Hello

with Superset 3.1.1, Error is not precise when 2 database connexions use the same display name
image

Regards

How to reproduce the bug

Just create 2 database connexion with the same display name

Screenshots/recordings

No response

Superset version

master / latest-dev

Python version

3.9

Node version

16

Browser

Chrome

Additional context

No response

Checklist

  • I have searched Superset docs and Slack and didn't find a solution to my problem.
  • I have searched the GitHub issue tracker and didn't find a similar bug report.
  • I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.
@rusackas
Copy link
Member

rusackas commented Apr 29, 2024

Do you mean to say you'd like it to:

  1. Throw an error saying "Database name _____ is in use. Please give your database connection a unique name"
  2. Let you name databases with the same name?

I hope you mean (1), as (2) would cause a lot of confusion/problems

@xavier-GitHub76
Copy link
Contributor Author

Hello,
I mean (1).
In this use case, with a error message more precise (like your proposition "Please give your database connection a unique name"), the user would immediately know that he must change his connection display name.
Best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants