Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider step size is incorrect in some cases #28253

Closed
2 of 3 tasks
eyalezer opened this issue Apr 28, 2024 · 0 comments
Closed
2 of 3 tasks

Slider step size is incorrect in some cases #28253

eyalezer opened this issue Apr 28, 2024 · 0 comments

Comments

@eyalezer
Copy link
Contributor

Bug description

Due to this PR: #27271 the step size is rounded to 1 in cases max - min is greater than 1, for example in case max = 1.75 and min = 0.25 the slider step size will be set to 1 and therefor this will be the only slider option available when using it.
There are multiple ways of resolving this issue for instance having a bigger minimum number when comparing at line: RangeFilterPlugin.tsx:311 or having another controlPanel config for the filter to set the step size manually or the delta value like suggested before.

Before raising any PR i would like hear what you guys think regarding the different options we can tackle this issue

How to reproduce the bug

have max and min delta value grater than 1

Screenshots/recordings

No response

Superset version

3.1.2

Python version

3.9

Node version

16

Browser

Chrome

Additional context

No response

Checklist

  • I have searched Superset docs and Slack and didn't find a solution to my problem.
  • I have searched the GitHub issue tracker and didn't find a similar bug report.
  • I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.
@eyalezer eyalezer closed this as not planned Won't fix, can't repro, duplicate, stale May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant