Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C#] Fury support for C# #686

Open
jiangguilong2000 opened this issue Jul 18, 2023 · 8 comments
Open

[C#] Fury support for C# #686

jiangguilong2000 opened this issue Jul 18, 2023 · 8 comments
Labels
c# enhancement New feature or request

Comments

@jiangguilong2000
Copy link

for unity game development

@jiangguilong2000 jiangguilong2000 added the enhancement New feature or request label Jul 18, 2023
@chaokunyang chaokunyang added the c# label Jul 18, 2023
@chaokunyang chaokunyang changed the title Looking forward to supporting C# as much as possible [C#] Fury serialization support for C# Jul 18, 2023
@chaokunyang
Copy link
Collaborator

chaokunyang commented Jul 18, 2023

@jiangguilong2000 Thanks for submitting this issue. As a multi-language serialization framework, c# support is important for fury. But we don't have experience for c#. Maybe someone in the community are interested to take this issue.

@iceboundrock
Copy link

C#/.net already has a good foundation for this, like Expression Trees, which can save quite a lot of effort. I am working on a very preliminary C# port on top of Fury java implementation, but I cannot commit to anything yet.

@chaokunyang
Copy link
Collaborator

chaokunyang commented Jul 21, 2023

C#/.net already has a good foundation for this, like Expression Trees, which can save quite a lot of effort. I am working on a very preliminary C# port on top of Fury java implementation, but I cannot commit to anything yet.

@iceboundrock that would be very great, looking forward to it. Let us know if there are anything we can help. We're formalize our cross language protocol into a text spec. But it may still take some time. The csharp poc can skip protocol alignment and do it in the future

@nfsfairytale
Copy link

hope support c#

@chaokunyang chaokunyang pinned this issue Oct 8, 2023
@chaokunyang chaokunyang changed the title [C#] Fury serialization support for C# [C#] Fury support for C# Oct 8, 2023
@chaokunyang
Copy link
Collaborator

hope support c#

Glad to see more demands for this, pined the issue to prioritize it!
Hope this can help it get supported sooner.

@chaokunyang chaokunyang unpinned this issue Oct 20, 2023
@chaokunyang chaokunyang pinned this issue Oct 20, 2023
@jpfed
Copy link

jpfed commented Oct 26, 2023

@iceboundrock Expression trees sound like a great idea for selectively deserializing fields. On the serialization end, it may be worth considering source generators for optimum performance.

@chaokunyang
Copy link
Collaborator

chaokunyang commented Oct 26, 2023

@jpfed How about generate code at runtime? Generate source code statically will need users to integrate it with build pipeline, which may introduce extra user mind burden.

@chaokunyang
Copy link
Collaborator

https://fury.apache.org/docs/specification/fury_xlang_serialization_spec is our cross-language serialization spec, anyone interested at this issue can take a look at this document to know how to implement C# for fury

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c# enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants