Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete hightlight and downplay doc #279

Closed
wants to merge 8 commits into from
Closed

Conversation

gitforhlp
Copy link

en/api/action.md Outdated
@@ -36,54 +36,6 @@ Chart actions supported by ECharts are triggered through [dispatchAction](~echar

**Attention: ** The `?:` note in the code shows that this attribute is optional. *EVENT:* stands for the event that triggers action.

## highlight(Action)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't remove them as they are still working for other series or components.

The v5 upgrade guide indicates that the highlight action & downplay action in the sunburst series are deprecated but not in all series.

Perhaps we should add new actions for sunburstHighlight & sunburstUnhighlight.

@Ovilia
Copy link
Contributor

Ovilia commented Aug 24, 2022

@pissang Please help review this PR.

@pissang
Copy link
Contributor

pissang commented Aug 29, 2022

As @plainheart said, this change is only scoped to the sunburst series, it should be mentioned in the note

@pissang
Copy link
Contributor

pissang commented Aug 29, 2022

I was confused because highlight is new introduced since 5.0 and it should not be deprecated. So I just did some search in the code and it seems the warning log is wrong in https://github.com/apache/echarts/blob/master/src/chart/sunburst/sunburstAction.ts#L90

It should be.

deprecateReplaceLog('sunburstHighlight', 'highlight');

So we should change this warning log instead of changing the doc

@gitforhlp
Copy link
Author

It is stated in the V5 upgrade document that this is discarded in the sunrise chart,please check again
https://echarts.apache.org/handbook/zh/basics/release-note/v5-upgrade-guide#%E4%B8%8D%E5%86%8D%E6%8E%A8%E8%8D%90%E4%BD%BF%E7%94%A8%E7%9A%84-api

旭日图(sunburst):
动作类型 highlight 已被弃用,请使用 sunburstHighlight 代替。
动作类型 downplay 已被弃用,请使用 sunburstUnhighlight 代替。
选项 series.downplay 已被弃用,请使用 series.blur 代替。
选项 series.highlightPolicy 已不适用,请使用 series.emphasis.focus 代替。

@Ovilia
Copy link
Contributor

Ovilia commented Aug 29, 2022

apache/echarts#17587 is following the right track. I think there should be no document changing required so I'm going to close this PR. Thanks for the help!

@Ovilia Ovilia closed this Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants