feat: Support spark unbase64 function #425
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
reviewed
May 14, 2024
| @@ -2073,6 +2073,13 @@ object QueryPlanSerde extends Logging with ShimQueryPlanSerde with CometExprShim | |||
| scalarExprToProtoWithReturnType(algorithm, StringType, childExpr) | |||
| } | |||
|
|
|||
| case a: UnBase64 => | |||
| val newExpr = unbase64Serde(a) | |||
There was a problem hiding this comment.
Could you add a TODO for the unsupported failOnError?
viirya
reviewed
May 14, 2024
Comment on lines
+1483
to
+1486
| sql("create table t2(col string) using parquet") | ||
| sql("insert into t2 select base64(col) from t1") | ||
|
|
||
| checkSparkAnswerAndOperator("SELECT unbase64(col) FROM t2") |
There was a problem hiding this comment.
Why we need to insert base64(col) into t2 before comparing? Cannot we just check the results of select base64(col) from t1?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #423 .
Rationale for this change
What changes are included in this PR?
How are these changes tested?