Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve CometCastSuite framework for checking for expected error messages #402

Open
andygrove opened this issue May 8, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@andygrove
Copy link
Member

What is the problem the feature request solves?

In CometCastSuite we have a shared method castTest which executes queries against Spark and Comet and compares results.

In the case where we expect the cast to fail, we compare error messages.

When running against Spark 3.4 we expect the error messages to be identical, but for 3.2 and 3.3 we have been adding custom handling for different types of errors, and this area of code is becoming a bit hacky (my bad) and I think we need a better mechanism.

I propose adding a capability for individual tests to provide their own lambda functions for checking for expected errors. I plan on creating a PR with a proposal.

Describe the potential solution

No response

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant