feat: Add HashJoin support for BuildRight #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
force-pushed
the
hash_join_build_right
branch
from
152df93
to
383ff05
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #437 +/- ##
============================================
+ Coverage 34.17% 34.30% +0.13%
- Complexity 850 855 +5
============================================
Files 116 116
Lines 38547 38653 +106
Branches 8523 8545 +22
============================================
+ Hits 13172 13259 +87
- Misses 22609 22647 +38
+ Partials 2766 2747 -19 ☔ View full report in Codecov by Sentry. |
viirya
commented
May 21, 2024
Comment on lines
2420
to
2425
| join match { | ||
| case b: BroadcastHashJoinExec if b.isNullAwareAntiJoin => | ||
| // DataFusion HashJoin LeftAnti has bugs on null keys. | ||
| withInfo(join, "DataFusion doesn't support null-aware anti join") | ||
| return None | ||
| case _ => // no-op |
viirya
force-pushed
the
hash_join_build_right
branch
from
ee5952e
to
9e25a6a
Compare
|
This requires apache/datafusion#10702 to be in DataFusion new release. |
andygrove
reviewed
May 29, 2024
| @@ -352,7 +352,7 @@ index 7dec558f8df..840dda15033 100644 | |||
| assert(exchanges.size == 2) | |||
| } | |||
| diff --git a/sql/core/src/test/scala/org/apache/spark/sql/DynamicPartitionPruningSuite.scala b/sql/core/src/test/scala/org/apache/spark/sql/DynamicPartitionPruningSuite.scala | |||
| index f33432ddb6f..060f874ea72 100644 | |||
| index f33432ddb6f..9cf7a9dd4e3 100644 | |||
There was a problem hiding this comment.
I guess we need the same change for 3.4.3.diff ?
viirya
force-pushed
the
hash_join_build_right
branch
from
d41a68e
to
d494b4f
Compare
andygrove
approved these changes
May 30, 2024
andygrove
reviewed
May 30, 2024
kazuyukitanimura
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #390.
Rationale for this change
What changes are included in this PR?
How are these changes tested?