Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR build for Linux Java 11 with Spark 3.4 is not running #389

Closed
kazuyukitanimura opened this issue May 6, 2024 · 5 comments
Closed

PR build for Linux Java 11 with Spark 3.4 is not running #389

kazuyukitanimura opened this issue May 6, 2024 · 5 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@kazuyukitanimura
Copy link
Contributor

kazuyukitanimura commented May 6, 2024

Describe the bug

The github action PR build for Linux Java 11 with Spark 3.4 is not running

Steps to reproduce

Looks like the variable substitution is not working, i.e. PR Build / ${{ matrix.os }}/java ${{ matrix.java_version }}-spark-${{ matrix.spark-version }}/${{

Expected behavior

We should run tests for Java 11

Additional context

No response

@kazuyukitanimura kazuyukitanimura added the bug Something isn't working label May 6, 2024
@kazuyukitanimura kazuyukitanimura changed the title PR build for Linux Java 11 is not running PR build for Linux Java 11 with Spark 3.4 is not running May 6, 2024
@kazuyukitanimura
Copy link
Contributor Author

Screenshot 2024-05-06 at 10 30 18 AM

@viirya viirya added the help wanted Extra attention is needed label May 6, 2024
@advancedxy
Copy link
Contributor

Java 11 is excluded on purpose on pull request event as there are already too much combinations. Java8 and Java17 with Spark 3.4 on Linux are tested, which should be sufficient? They are all tested in a post-commit event though.

@kazuyukitanimura
Copy link
Contributor Author

Thanks @advancedxy Do you know the original reason why this specific combination was excluded by any chance?

@advancedxy
Copy link
Contributor

There's quota limit per repo for github runners(might not be a problem for apache project but for the forked ones) and we thought it would be sufficient to cover Java8(oldest) and Java17(quite the latest) with Spark 3.4 on Linux runners for pull requests. In that way, the runners required to run PR actions is reduced. The power consumption is reduced as well😁.

Is there any specific need to run Java11, such as it's the java version used in your production? If so, I think we can replace java 17/8 with java11.

@kazuyukitanimura
Copy link
Contributor Author

Thanks. Looks like this is the history #122
We can keep it as is for now. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants