Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write a guide on contributing a new expression #370

Open
andygrove opened this issue May 1, 2024 · 3 comments
Open

Write a guide on contributing a new expression #370

andygrove opened this issue May 1, 2024 · 3 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@andygrove
Copy link
Member

What is the problem the feature request solves?

We should write a detailed guide showing new contributors how to add support for a new expression in Comet. This would cover the Scala, Protobuf, and Rust changes, as well as testing approaches. We could create this based on a recent PR that added a new expression.

Describe the potential solution

No response

Additional context

No response

@andygrove andygrove added documentation Improvements or additions to documentation enhancement New feature or request labels May 1, 2024
@tshauck
Copy link
Contributor

tshauck commented May 3, 2024

Once #342 is approved/merged and if it's an appropriate example, I'd be happy to write this based off that work.

@parthchandra
Copy link
Contributor

Also related to adding a new expression is adding a new aggregate expression (for example: 49bf503)

@andygrove
Copy link
Member Author

And I suppose we also need a separate guide on adding cast expressions since there are specific test considerations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants