-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revisit axios-cookiejar-support #295
Comments
I think another feasible option would be to remove additional cookie-handling dependencies altogether from |
May also be worth considering reducing reliance on axios altogether, especially now that the |
@aeharding I was thinking about that. That would be a dream. Unfortunately, we'll have to wait until node 18 is the norm. |
In the 10.0.0 dependency bump, axios-cookiejar-support was left at
^1.0.1
when the latest is2.0.4
. Why wasn't this updated in line with the others? Well...axios-cookiejar-support
has changed - this is not a big deal. Usage is https://github.com/3846masa/axios-cookiejar-support#usageaxios-cookiejar-support
doesn't like our use of custom http/https agents. In fact it refuses to run when they are supplied.Error [axios-cookiejar-support does not support for use with other http(s).Agent.].
Others have spotted this and the developer's advise is here 3846masa/axios-cookiejar-support#431. In short:
axios-cookiejar-support
axios-cookiejar-support
Doing it this way may also eliminate this bug at the same time: #264.
This seems like it's worth a try, but didn't want to hold up v10 (any more than it was) while fiddling with it.
The text was updated successfully, but these errors were encountered: