Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse icon in the main left menu is ambiguous #1257

Open
gordey4doronin opened this issue Mar 31, 2020 · 1 comment
Open

Collapse icon in the main left menu is ambiguous #1257

gordey4doronin opened this issue Mar 31, 2020 · 1 comment

Comments

@gordey4doronin
Copy link

Disclaimer. This is just a nitpick UI issue and doesn't affect any functionality in general.

  1. So the main left menu is collapsible. But the icon is a little bit confusing when in the maximized state. It looks like a sign-out icon, which you struggle to click cause you don't want to be signed out.

  2. Also collapse and expand button are kinda inconsistent.

Current Behavior

Collapse

Screenshot 2020-03-31 at 18 55 04

Expand

Screenshot 2020-03-31 at 18 54 52

Possible Solution

With the existing icon set the number of possible solutions is not really high.
But I believe it's still possible to find icons which would fit better.
As a fast example I tried icon-double-angle-left and icon-double-angle-right.

Collapse

Screenshot 2020-03-31 at 19 11 41

Expand

Screenshot 2020-03-31 at 19 12 54

P.S. After checking the code I figured it is actually a sign-in icon (but flipped) indeed. So my initial feeling that it would sign me out was reasonable at least. 😄

const icon = isMinimized ?
'icon-resize-horizontal' :
'icon-signin faux-navbar__burger__icon--flipped';

@popojargo
Copy link
Member

popojargo commented Apr 8, 2020

I'm 👍 for something like this. It would make a lot more sense! Using a hamburger icon would also make it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants