Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal *-Info.plist filter behavior not properly tested #826

Open
brodybits opened this issue Apr 16, 2020 · 0 comments
Open

internal *-Info.plist filter behavior not properly tested #826

brodybits opened this issue Apr 16, 2020 · 0 comments

Comments

@brodybits
Copy link
Contributor

From review of changes that were proposed in PR #765, I discovered that the following change would not cause a test failure:

diff --git a/bin/templates/scripts/cordova/lib/projectFile.js b/bin/templates/scripts/cordova/lib/projectFile.js
index 35a5a917..6ab43422 100644
--- a/bin/templates/scripts/cordova/lib/projectFile.js
+++ b/bin/templates/scripts/cordova/lib/projectFile.js
@@ -41,7 +41,7 @@ function parseProjectFile (locations) {
     xcodeproj.parseSync();
 
     const xcBuildConfiguration = xcodeproj.pbxXCBuildConfigurationSection();
-    const plist_file_entry = _.find(xcBuildConfiguration, entry => entry.buildSettings && entry.buildSettings.INFOPLIST_FILE);
+    const plist_file_entry = _.find(xcBuildConfiguration, entry => entry.buildSettings);
     const plist_file = path.join(project_dir, plist_file_entry.buildSettings.INFOPLIST_FILE.replace(/^"(.*)"$/g, '$1').replace(/\\&/g, '&'));
     const config_file = path.join(path.dirname(plist_file), 'config.xml');
 

Considering that this internal filter needs to be adapted to resolve issue #764, I would conclude that this indicates a missing test case.

This should be part of the list of plist/config.xml issues in #793. At this point I am unsure whether these issues are all the same or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant